test: multiple tab #8304
Open
test: multiple tab #8304
+100
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CurryYangxx
force-pushed
the
feat/multiple-tab
branch
from
62ad908 to
cec5994
Compare
CurryYangxx
force-pushed
the
test/multiple-tab
branch
from
a88c2ca to
f71abc8
Compare
CurryYangxx
force-pushed
the
test/multiple-tab
branch
from
f71abc8 to
2e66788
Compare
CurryYangxx
force-pushed
the
test/multiple-tab
branch
from
a8f3f29 to
d7d87ef
Compare
jackkav
reviewed
Jan 27, 2025
| test('change icon after change request method', async ({ page }) => { | ||
| await page.getByLabel('Create in collection').click(); | ||
| await page.getByLabel('HTTP Request').click(); | ||
| await page.waitForTimeout(1000); |
There was a problem hiding this comment.
waits are a test smell and should always be avoided at al costs as they do not scale.
They also often also indicated an underlying issue. Its worth getting to the bottom of whats happening to cause your action to to result in an immediate change to the ui you're interested in.
There was a problem hiding this comment.
could be remedied by dealing with the refs, ideally the test would also be scoped into the first PR, so its cool to merge this one in sooner rather than later
jackkav
reviewed
Jan 27, 2025
| await page.getByLabel('Request collection', { exact: true }).click(); | ||
| await page.getByPlaceholder('My Collection').fill('Test add tab collection'); | ||
| await page.getByRole('button', { name: 'Create', exact: true }).click(); | ||
| await page.waitForTimeout(1000); |
jackkav
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
smoke test for #8151 feature.